search

vmware-tanzu / asset-relocation-tool-for-kubernetes

A tool for relocating Kubernetes Assets
Other
42 stars 5 forks source link

CI doesn't run lint #56

Closed petewall closed 3 years ago

migmartri commented 3 years ago

It does run as github action https://github.com/vmware-tanzu/asset-relocation-tool-for-kubernetes/actions

Or do you mean that that's not even working? I can see the check being added to all my PRs

migmartri commented 3 years ago

btw, the reason I decided to go with linting using github actions instead of our concourse CI is because

1 - GH action is the recommended approach and it's implementation is trivial 2 - They recommend running as an standalone pipeline. Github treats it as an additional check 3 - It's aligned with https://github.com/vmware-tanzu/asset-relocation-tool-for-kubernetes/issues/25

petewall commented 3 years ago

I finished this work (in PR https://github.com/vmware-tanzu/asset-relocation-tool-for-kubernetes/pull/59) because it removes goimports and as long as we have the concourse ci running, I'd like to see it in both.

It's also useful exercise for me that I can take to my other go projects.

petewall commented 3 years ago

This is done now