vmware-tanzu / community-edition

VMware Tanzu Community Edition is no longer an actively maintained project. Code is available for historical purposes only.
https://tanzucommunityedition.io/
Apache License 2.0
1.34k stars 308 forks source link

Values file download has #@ lines #2081

Closed dbbaskette closed 2 years ago

dbbaskette commented 2 years ago

On Page:

The values file you are told to download has #@ lines at the top which will cause the install to error out

jpmcb commented 2 years ago

Hi @dbbaskette - as our docs note, the values files for packages use ytt to create templates for the configurations.

The #@ is ytt syntax and required for the templating to work

You can read more here about ytt: https://carvel.dev/ytt/

dbbaskette commented 2 years ago

This is specifically about https://quirky-franklin-8969be.netlify.app/docs/latest/package-readme-harbor-2.2.3/ The docs say to download the values file which has the ytt template syntax at the top, but you cannot submit a values file to package install that has those 2 lines.

jpmcb commented 2 years ago

Ah I see - correct, the values file won't be ingested correctly.

We have a few open PRs to address this since we are no longer recommending users download the values yaml file (since you've already seen it's problematic):