Closed seemiller closed 2 years ago
My guess is we weren't sure whether it was better to leave the ingress as 'an exercise to the user', or to include an ingress and hope that the defaults are ok for most users. If we include the ingress, will we need to (or want to) do something to make sure that contour gets installed first? I think there might also be a security concern about having the ingress on by default.
I agree that an ingress right now has a dependency on contour, and also would require proper AuthZ to Grafana (or all open). This is one of the downsides of the addons. There should be some documentation once the addon is applied/installed with next steps so that a user knows what to do. As an option, we can create the ingress (and whatever would be needed) if there's a config value that instructs the installation, (e.g. install_example: True), and then add an ytt template/overlay that does the necessary if the install_example is enabled. There's a related issue to this topic: https://github.com/vmware-tanzu/tce/issues/240
@stmcginnis @seemiller and I discussed and we're going to include a flag that will default and overlay to include a "generic" ingress object for happy path install
The Grafana add-on installs and runs on the cluster, however, there is no means to access it. There needs to be an ingress object bundled with this add-on to allow access to the dashboard.