search

vmware-tanzu / community-edition

VMware Tanzu Community Edition is no longer an actively maintained project. Code is available for historical purposes only.
https://tanzucommunityedition.io/
Apache License 2.0
1.33k stars 306 forks source link

Missing must-have labels in configmap restic-restore-action-config when enabling restic #5575

Closed jhuisss closed 1 year ago

jhuisss commented 1 year ago

https://github.com/vmware-tanzu/community-edition/blob/096a8bad98e1542c21ba7afd6d56b1a286b1411a/addons/packages/velero/1.9.2/bundle/config/overlays/velero/overlay-restic.yaml#L54

According to https://velero.io/docs/v1.9/restic/#customize-restore-helper-container, velero uses the labels to identify this comfigmap rather than the name, so the labels should be used in the ConfigMap.

  labels:
    # this value-less label identifies the ConfigMap as
    # config for a plugin (i.e. the built-in restic restore
    # item action plugin)
    velero.io/plugin-config: ""
    # this label identifies the name and kind of plugin
    # that this ConfigMap is for.
    velero.io/restic: RestoreItemAction
github-actions[bot] commented 1 year ago

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 30 days with no activity. If this issue is still relevant, please re-open a new issue.