Contour addon: validate values.yaml values

vmware-tanzu / community-edition

VMware Tanzu Community Edition is no longer an actively maintained project. Code is available for historical purposes only.

https://tanzucommunityedition.io/

Apache License 2.0

1.33k stars 307 forks source link

Contour addon: validate values.yaml values #696

Closed skriss closed 2 years ago

skriss commented 3 years ago

Feature Request

We should add validation functions to verify that the user has provided valid values.yaml values. These would be implemented in a .star file within the Contour addon dir.

Describe alternatives you've considered

N/A

Additional context

N/A

cc @vmware-tanzu/contour-owners

jorgemoralespou commented 3 years ago

There's an alternative mechanism via assertions: See as an example https://github.com/vmware-tanzu/tce/blob/main/addons/packages/knative-serving/bundle/config/overlays/assertions.yaml

jorgemoralespou commented 3 years ago

Latest Carvel ytt will provide schema for values.yaml (https://carvel.dev/ytt/docs/latest/ytt-schema/) Also, latest Carvel's Package API provides schema validation for the Package (https://carvel.dev/kapp-controller/docs/latest/packaging/#package-cr) using OpenAPiSchemav3.