Update Homebrew formula for `v0.11.0` release

karuppiah7890 commented 2 years ago

What this PR does / why we need it

Updates Homebrew formula for v0.11.0 release

Pending things to check by us

[x] ~Uninstall script~
[x] ~TODO comments in code except one (the one is around finding name of the plugins directory in tar ball)~
[x] ~Squash commits and have clear commit message(s)~

Which issue(s) this PR fixes

Fixes #26

Describe testing done for PR

On Linux -

$ uname
Linux

$ uname -a
Linux ip-10-0-0-27 5.11.0-1022-aws #23~20.04.1-Ubuntu SMP Mon Nov 15 14:03:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.3 LTS
Release:    20.04
Codename:   focal

$ brew install tanzu-community-edition    
==> Downloading https://github.com/vmware-tanzu/community-edition/releases/download/v0.10.0/tce-linux-amd64-v0.10.0.tar.gz
Already downloaded: /home/ubuntu/.cache/Homebrew/downloads/4da3ed5c742e12a15f718522da553d00d4b03bdb5019a2fd3676bcfbca202c1a--tce-linux-amd64-v0.10.0.tar.gz
==> Installing tanzu-community-edition from vmware-tanzu/tanzu
==> Thanks for installing Tanzu Community Edition!
==> The Tanzu CLI has been installed on your system
==> 

==> ******************************************************************************
==> * To initialize all plugins required by Tanzu Community Edition, an additional
==> * step is required. To complete the installation, please run the following
==> * shell script:
==> *
==> * /home/ubuntu/.linuxbrew/Cellar/tanzu-community-edition/v0.10.0/libexec/configure-tce.sh
==> *
==> ******************************************************************************
==> 

==> * To cleanup and remove Tanzu Community Edition from your system, run the
==> * following script:
==> /home/ubuntu/.linuxbrew/Cellar/tanzu-community-edition/v0.10.0/libexec/uninstall.sh
==> 

🍺  /home/ubuntu/.linuxbrew/Cellar/tanzu-community-edition/v0.10.0: 18 files, 741.9MB, built in 9 seconds
==> Running `brew cleanup tanzu-community-edition`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).

$ /home/ubuntu/.linuxbrew/Cellar/tanzu-community-edition/v0.10.0/libexec/configure-tce.sh
MY_DIR: /home/ubuntu/.linuxbrew/Cellar/tanzu-community-edition/v0.10.0/libexec
/home/ubuntu/.local/share
Removing old plugin cache from /home/ubuntu/.cache/tanzu/catalog.yaml
Making a backup of your Kubernetes config files into /tmp
| initializing ✔  successfully initialized CLI 
Installation complete!

$ tanzu version
version: v0.10.1
buildDate: 2022-02-14
sha: 401d55b

$ tanzu 
Tanzu CLI

Usage:
  tanzu [command]

Available command groups:

  Admin
    builder                 Build Tanzu components 
    codegen                 Tanzu code generation tool 

  Run
    cluster                 Kubernetes cluster operations 
    conformance             Run Sonobuoy conformance tests against clusters 
    diagnostics             Cluster diagnostics 
    kubernetes-release      Kubernetes release operations 
    management-cluster      Kubernetes management cluster operations 
    package                 Tanzu package management 
    secret                  Tanzu secret management 
    standalone-cluster      (!!! deprecated - see unmanaged-cluster !!!) Create clusters without a dedicated management cluster 
    unmanaged-cluster       Deploy and manage single-node, static, Tanzu clusters. 

  System
    completion              Output shell completion code 
    config                  Configuration for the CLI 
    init                    Initialize the CLI 
    login                   Login to the platform 
    plugin                  Manage CLI plugins 
    update                  Update the CLI 
    version                 Version information 

Flags:
  -h, --help   help for tanzu

Use "tanzu [command] --help" for more information about a command. 

Not logged in

$ tanzu builder version
v0.10.1

$ tanzu codegen version
v0.10.1

$ tanzu cluster version
v0.10.1

$ tanzu conformance version
Sonobuoy Version: v0.53.2
TCE Version: v0.10.0
TCE SHA 57d28405

$ tanzu diagnostics version
v0.10.0

$ tanzu kubernetes-release version
v0.10.1

$ tanzu management-cluster version
v0.10.1

$ tanzu package version
v0.10.1

$ tanzu secret version
v0.10.1

$ tanzu standalone-cluster version
v0.10.0

$ tanzu unmanaged-cluster version
v0.10.0

$ tanzu login version
v0.10.1

$ brew upgrade --formula tanzu-community-edition.rb
==> Upgrading 1 outdated package:
tanzu-community-edition v0.10.0 -> v0.11.0-rc.2
==> Downloading https://github.com/vmware-tanzu/community-edition/releases/download/v0.11.0-rc.2/tce-linux-amd64-v0.11.0-rc.
Already downloaded: /home/ubuntu/.cache/Homebrew/downloads/1adb2d45703b939647965800d03862e635802ab9f12ba33d82c06eacf9d158b5--tce-linux-amd64-v0.11.0-rc.2.tar.gz
==> Upgrading tanzu-community-edition
  v0.10.0 -> v0.11.0-rc.2 

==> Thanks for installing Tanzu Community Edition!
==> The Tanzu CLI has been installed on your system
==> 

==> ******************************************************************************
==> * To initialize all plugins required by Tanzu Community Edition, an additional
==> * step is required. To complete the installation, please run the following
==> * shell script:
==> *
==> * /home/ubuntu/.linuxbrew/Cellar/tanzu-community-edition/v0.11.0-rc.2/libexec/configure-tce.sh
==> *
==> ******************************************************************************
==> 

==> * To cleanup and remove Tanzu Community Edition from your system, run the
==> * following script:
==> /home/ubuntu/.linuxbrew/Cellar/tanzu-community-edition/v0.11.0-rc.2/libexec/uninstall.sh
==> 

🍺  /home/ubuntu/.linuxbrew/Cellar/tanzu-community-edition/v0.11.0-rc.2: 29 files, 826.0MB, built in 10 seconds
==> Running `brew cleanup tanzu-community-edition`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
Removing: /home/ubuntu/.linuxbrew/Cellar/tanzu-community-edition/v0.10.0... (18 files, 741.9MB)

$ /home/ubuntu/.linuxbrew/Cellar/tanzu-community-edition/v0.11.0-rc.2/libexec/configure-tce.sh
MY_DIR: /home/ubuntu/.linuxbrew/Cellar/tanzu-community-edition/v0.11.0-rc.2/libexec
/home/ubuntu/.local/share
Removing old plugin cache from /home/ubuntu/.cache/tanzu/catalog.yaml
Installing plugin 'builder:v0.11.2'
✔  successfully installed 'builder' plugin
Installing plugin 'codegen:v0.11.2'
✔  successfully installed 'codegen' plugin
Installing plugin 'cluster:v0.11.2'
✔  successfully installed 'cluster' plugin
Installing plugin 'kubernetes-release:v0.11.2'
✔  successfully installed 'kubernetes-release' plugin
Installing plugin 'login:v0.11.2'
✔  successfully installed 'login' plugin
Installing plugin 'management-cluster:v0.11.2'
✔  successfully installed 'management-cluster' plugin
Installing plugin 'package:v0.11.2'
✔  successfully installed 'package' plugin
Installing plugin 'pinniped-auth:v0.11.2'
✔  successfully installed 'pinniped-auth' plugin
Installing plugin 'secret:v0.11.2'
✔  successfully installed 'secret' plugin
Installing plugin 'conformance:v0.11.0-rc.2'
✔  successfully installed 'conformance' plugin
Installing plugin 'diagnostics:v0.11.0-rc.2'
✔  successfully installed 'diagnostics' plugin
Installing plugin 'unmanaged-cluster:v0.11.0-rc.2'
✔  successfully installed 'unmanaged-cluster' plugin
Making a backup of your Kubernetes config files into /tmp

$ tanzu version
version: v0.11.2
buildDate: 2022-03-17
sha: 6431d1d

$ tanzu 
Tanzu CLI

Usage:
  tanzu [command]

Available command groups:

  Admin
    builder                 Build Tanzu components 
    codegen                 Tanzu code generation tool 

  Run
    cluster                 Kubernetes cluster operations 
    conformance             Run Sonobuoy conformance tests against clusters 
    diagnostics             Cluster diagnostics 
    kubernetes-release      Kubernetes release operations 
    management-cluster      Kubernetes management cluster operations 
    package                 Tanzu package management 
    secret                  Tanzu secret management 
    unmanaged-cluster       Deploy and manage single-node, static, Tanzu clusters. 

  System
    completion              Output shell completion code 
    config                  Configuration for the CLI 
    init                    Initialize the CLI 
    login                   Login to the platform 
    plugin                  Manage CLI plugins 
    update                  Update the CLI 
    version                 Version information 

Flags:
  -h, --help   help for tanzu

Use "tanzu [command] --help" for more information about a command. 

Not logged in

$ tanzu builder version
v0.11.2

$ tanzu codegen version

v0.11.2

$ tanzu cluster version
v0.11.2

$ tanzu conformance version
Sonobuoy Version: v0.53.2
TCE Version: v0.11.0-rc.2
TCE SHA 05707fb3

$ tanzu diagnostics version
v0.11.0-rc.2

$ tanzu kubernetes-release version
v0.11.2

$ tanzu management-cluster version
v0.11.2

$ tanzu package version
v0.11.2

$ tanzu secret version
v0.11.2

$ tanzu standalone-cluster version
Error: unknown command "standalone-cluster" for "tanzu"
Run 'tanzu --help' for usage.

✖  unknown command "standalone-cluster" for "tanzu" 

$ tanzu unmanaged-cluster version
v0.11.0-rc.2

$ tanzu login version
v0.11.2

On Mac -

$ uname -a
Darwin karuppiahn-a01.vmware.com 21.4.0 Darwin Kernel Version 21.4.0: Mon Feb 21 20:34:37 PST 2022; root:xnu-8020.101.4~2/RELEASE_X86_64 x86_64

$ brew info tanzu-community-edition
vmware-tanzu/tanzu/tanzu-community-edition: stable v0.10.0, HEAD
Tanzu Community Edition
https://github.com/vmware-tanzu/community-edition
Not installed
From: https://github.com/vmware-tanzu/homebrew-tanzu/blob/HEAD/tanzu-community-edition.rb
==> Options
--HEAD
    Install HEAD version

$ brew install tanzu-community-edition
Running `brew update --preinstall`...
==> Auto-updated Homebrew!
Updated Homebrew from fed93bb93 to b1577d347.
Updated 6 taps (tilt-dev/tap, hashicorp/tap, homebrew/core, homebrew/cask, homebrew/services and vmware-tanzu/carvel).
==> New Formulae
epinio                                   ltex-ls                                  rslint
fourmolu                                 nickel                                   stylish-haskell
inih                                     postgraphile                             vmware-tanzu/carvel/kctrl
==> Updated Formulae
Updated 567 formulae.
==> Deleted Formulae
gstreamermm
==> New Casks
abbyy-finereader-pdf                     paragon-camptune                         rwts-pdfwriter
mediahuman-audio-converter               roonbridge                               unicopedia-plus
==> Updated Casks
Updated 235 casks.
==> Deleted Casks
finereader

==> Homebrew was updated to version 3.4.3
The changelog can be found at:
  https://github.com/Homebrew/brew/releases/tag/3.4.3
==> Downloading https://github.com/vmware-tanzu/community-edition/releases/download/v0.10.0/tce-darwin-amd64-v0.10.0.tar.g
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/303802332/b52f42d4-35cb-
######################################################################## 100.0%
==> Installing tanzu-community-edition from vmware-tanzu/tanzu
Warning: Your Xcode (13.2.1) is outdated.
Please update to Xcode 13.3 (or delete it).
Xcode can be updated from the App Store.

==> Thanks for installing Tanzu Community Edition!
==> The Tanzu CLI has been installed on your system
==> 

==> ******************************************************************************
==> * To initialize all plugins required by Tanzu Community Edition, an additional
==> * step is required. To complete the installation, please run the following
==> * shell script:
==> *
==> * /usr/local/Cellar/tanzu-community-edition/v0.10.0/libexec/configure-tce.sh
==> *
==> ******************************************************************************
==> 

==> * To cleanup and remove Tanzu Community Edition from your system, run the
==> * following script:
==> /usr/local/Cellar/tanzu-community-edition/v0.10.0/libexec/uninstall.sh
==> 

🍺  /usr/local/Cellar/tanzu-community-edition/v0.10.0: 18 files, 826.6MB, built in 8 seconds
==> Running `brew cleanup tanzu-community-edition`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).

$ /usr/local/Cellar/tanzu-community-edition/v0.10.0/libexec/configure-tce.sh
MY_DIR: /usr/local/Cellar/tanzu-community-edition/v0.10.0/libexec
/Users/karuppiahn/Library/Application Support
Removing old plugin cache from /Users/karuppiahn/.cache/tanzu/catalog.yaml
Making a backup of your Kubernetes config files into /tmp
| initializing ✔  successfully initialized CLI 
Installation complete!

$ tanzu version
version: v0.10.1
buildDate: 2022-02-14
sha: 401d55b

$ tanzu
Tanzu CLI

Usage:
  tanzu [command]

Available command groups:

  Admin
    builder                 Build Tanzu components 
    codegen                 Tanzu code generation tool 

  Run
    cluster                 Kubernetes cluster operations 
    conformance             Run Sonobuoy conformance tests against clusters 
    diagnostics             Cluster diagnostics 
    kubernetes-release      Kubernetes release operations 
    management-cluster      Kubernetes management cluster operations 
    package                 Tanzu package management 
    secret                  Tanzu secret management 
    standalone-cluster      (!!! deprecated - see unmanaged-cluster !!!) Create clusters without a dedicated management cluster 
    unmanaged-cluster       Deploy and manage single-node, static, Tanzu clusters. 

  System
    completion              Output shell completion code 
    config                  Configuration for the CLI 
    init                    Initialize the CLI 
    login                   Login to the platform 
    plugin                  Manage CLI plugins 
    update                  Update the CLI 
    version                 Version information 

Flags:
  -h, --help   help for tanzu

Use "tanzu [command] --help" for more information about a command. 

Not logged in

$ tanzu builder version
v0.10.1

$ tanzu codegen version
v0.10.1

$ tanzu cluster version
v0.10.1

$ tanzu conformance version
Sonobuoy Version: v0.53.2
TCE Version: v0.10.0
TCE SHA 57d28405

$ tanzu diagnostics version
v0.10.0

$ tanzu kubernetes-release version
v0.10.1

$ tanzu management-cluster version
v0.10.1

$ tanzu package version
v0.10.1

$ tanzu secret version
v0.10.1

$ tanzu standalone-cluster version
v0.10.0

$ tanzu unmanaged-cluster version
v0.10.0

$ tanzu login version
v0.10.1

$ brew upgrade --formula tanzu-community-edition.rb 
Running `brew update --preinstall`...
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/cask).
==> Updated Casks
Updated 1 cask.

==> Upgrading 1 outdated package:
tanzu-community-edition v0.10.0 -> v0.11.0-rc.2
==> Downloading https://github.com/vmware-tanzu/community-edition/releases/download/v0.11.0-rc.2/tce-darwin-amd64-v0.11.0-
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/303802332/efb2b6c9-5573-
######################################################################## 100.0%
==> Upgrading tanzu-community-edition
  v0.10.0 -> v0.11.0-rc.2 

Warning: Your Xcode (13.2.1) is outdated.
Please update to Xcode 13.3 (or delete it).
Xcode can be updated from the App Store.

==> Thanks for installing Tanzu Community Edition!
==> The Tanzu CLI has been installed on your system
==> 

==> ******************************************************************************
==> * To initialize all plugins required by Tanzu Community Edition, an additional
==> * step is required. To complete the installation, please run the following
==> * shell script:
==> *
==> * /usr/local/Cellar/tanzu-community-edition/v0.11.0-rc.2/libexec/configure-tce.sh
==> *
==> ******************************************************************************
==> 

==> * To cleanup and remove Tanzu Community Edition from your system, run the
==> * following script:
==> /usr/local/Cellar/tanzu-community-edition/v0.11.0-rc.2/libexec/uninstall.sh
==> 

🍺  /usr/local/Cellar/tanzu-community-edition/v0.11.0-rc.2: 29 files, 927.8MB, built in 6 seconds
==> Running `brew cleanup tanzu-community-edition`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
Removing: /usr/local/Cellar/tanzu-community-edition/v0.10.0... (18 files, 826.6MB)

$ /usr/local/Cellar/tanzu-community-edition/v0.11.0-rc.2/libexec/configure-tce.sh
MY_DIR: /usr/local/Cellar/tanzu-community-edition/v0.11.0-rc.2/libexec
/Users/karuppiahn/Library/Application Support
Removing old plugin cache from /Users/karuppiahn/.cache/tanzu/catalog.yaml
Installing plugin 'builder:v0.11.2'
✔  successfully installed 'builder' plugin
Installing plugin 'codegen:v0.11.2'
✔  successfully installed 'codegen' plugin
Installing plugin 'cluster:v0.11.2'
✔  successfully installed 'cluster' plugin
Installing plugin 'kubernetes-release:v0.11.2'
✔  successfully installed 'kubernetes-release' plugin
Installing plugin 'login:v0.11.2'
✔  successfully installed 'login' plugin
Installing plugin 'management-cluster:v0.11.2'
✔  successfully installed 'management-cluster' plugin
Installing plugin 'package:v0.11.2'
✔  successfully installed 'package' plugin
Installing plugin 'pinniped-auth:v0.11.2'
✔  successfully installed 'pinniped-auth' plugin
Installing plugin 'secret:v0.11.2'
✔  successfully installed 'secret' plugin
Installing plugin 'conformance:v0.11.0-rc.2'
✔  successfully installed 'conformance' plugin
Installing plugin 'diagnostics:v0.11.0-rc.2'
✔  successfully installed 'diagnostics' plugin
Installing plugin 'unmanaged-cluster:v0.11.0-rc.2'
✔  successfully installed 'unmanaged-cluster' plugin
Making a backup of your Kubernetes config files into /tmp

$ tanzu version
version: v0.11.2
buildDate: 2022-03-17
sha: 6431d1d

$ tanzu 
Tanzu CLI

Usage:
  tanzu [command]

Available command groups:

  Admin
    builder                 Build Tanzu components 
    codegen                 Tanzu code generation tool 

  Run
    cluster                 Kubernetes cluster operations 
    conformance             Run Sonobuoy conformance tests against clusters 
    diagnostics             Cluster diagnostics 
    kubernetes-release      Kubernetes release operations 
    management-cluster      Kubernetes management cluster operations 
    package                 Tanzu package management 
    secret                  Tanzu secret management 
    unmanaged-cluster       Deploy and manage single-node, static, Tanzu clusters. 

  System
    completion              Output shell completion code 
    config                  Configuration for the CLI 
    init                    Initialize the CLI 
    login                   Login to the platform 
    plugin                  Manage CLI plugins 
    update                  Update the CLI 
    version                 Version information 

Flags:
  -h, --help   help for tanzu

Use "tanzu [command] --help" for more information about a command. 

Not logged in

$ tanzu builder version
v0.11.2

$ tanzu codegen version
v0.11.2

$ tanzu cluster version
tanzu conformance version
tanzu diagnostics version
tanzu kubernetes-release version
tanzu management-cluster version
tanzu package version
tanzu secret version
tanzu standalone-cluster version
tanzu unmanaged-cluster version
tanzu login version
v0.11.2

$ tanzu conformance version
Sonobuoy Version: v0.53.2
TCE Version: v0.11.0-rc.2
TCE SHA 05707fb3

$ tanzu diagnostics version
v0.11.0-rc.2

$ tanzu kubernetes-release version
v0.11.2

$ tanzu management-cluster version
v0.11.2

$ tanzu package version
v0.11.2

$ tanzu secret version
v0.11.2

$ tanzu standalone-cluster version
Error: unknown command "standalone-cluster" for "tanzu"
Run 'tanzu --help' for usage.

✖  unknown command "standalone-cluster" for "tanzu" 

$ tanzu unmanaged-cluster version
v0.11.0-rc.2

$ tanzu login version
v0.11.2

Special notes for your reviewer

Questions

Do we want debugging capability similar to https://github.com/vmware-tanzu/community-edition/blob/main/hack/release/install.sh , https://github.com/vmware-tanzu/community-edition/blob/main/hack/release/uninstall.sh ? Like https://github.com/vmware-tanzu/community-edition/blob/0e6bdba2ef85f66e1dc219e81e0ab72e0e64cdab/hack/release/install.sh#L12 , https://github.com/vmware-tanzu/community-edition/blob/0e6bdba2ef85f66e1dc219e81e0ab72e0e64cdab/hack/release/uninstall.sh#L12

This PR currently uses the version as v0.11.0-rc.2 and it's respective SHA sum for Linux and MacOS tar balls, which we need to update before merging the PR

We need to merge this PR only after we release v0.11.0

Things that the reviewer needs to check

Install
Configure
Uninstall

karuppiah7890 commented 2 years ago

I think the error in the check is happening in the kube config backup stage not sure though https://github.com/vmware-tanzu/homebrew-tanzu/runs/5674398679?check_suite_focus=true#step:3:445

joshrosso commented 2 years ago

cc @dvonthenen @seemiller to check this out!

thanks!

karuppiah7890 commented 2 years ago

Going forward, can we think about how we can avoid the duplication in TCE repo install script and the TCE formula code? Or at least have some way to ensure that when we change the install script (bash, bat) then we also make changes in the Homebrew formula and the Chocolatey install and uninstall scripts, as it's all related, so, whoever makes these changes will have context and will be able to make the atomic change of modifying the installation / uninstallation logic in all places - standalone install scripts, homebrew and chocolatey package code

cc @joshrosso @dvonthenen @stmcginnis

dvonthenen commented 2 years ago

Going forward, can we think about how we can avoid the duplication in TCE repo install script and the TCE formula code? Or at least have some way to ensure that when we change the install script (bash, bat) then we also make changes in the Homebrew formula and the Chocolatey install and uninstall scripts, as it's all related, so, whoever makes these changes will have context and will be able to make the atomic change of modifying the installation / uninstallation logic in all places - standalone install scripts, homebrew and chocolatey package code

cc @joshrosso @dvonthenen @stmcginnis

The goal of the each of them are slightly different which is why they are separate currently. Install shouldn't be a problem and is probably the same. Uninstall there could be opportunity to consolidate, but there is also mention of UI based install which we should coordinate with.

The uninstall.sh/.bat is really meant for developers who are looking to completely delete everything from their system.

For end users, this is undesirable. There is some configuration we want to leave around in case we do an uninstall and then reinstall. We don't want to blow away things like the downloaded BOM and k8s configs.

karuppiah7890 commented 2 years ago

@dvonthenen Shall we make the changes in #28 PR in this PR itself? We don't need to merge two PRs, however we can't merge formula for RC.2 , that would be weird, though we might immediately merge the other PR #28 in which case users will get only the latest Homebrew tap git repo after that point

dvonthenen commented 2 years ago

@dvonthenen Shall we make the changes in #28 PR in this PR itself? We don't need to merge two PRs, however we can't merge formula for RC.2 , that would be weird, though we might immediately merge the other PR #28 in which case users will get only the latest Homebrew tap git repo after that point

If you want to include the changes for PR 28 in this one, it shouldn't really matter. We could merge 2 PRs or just 1. If you want to include, I can close the other PR and this should be done ASAP since we are releasing at 6am tomorrow.

On your other point, I'm not sure I understand the other part of your comment. We shouldn't allow users to access rc2 or any other pre-release (alpha, beta or rc) though homebrew (or choco). The end users should only be able to install final GA releases.

karuppiah7890 commented 2 years ago

On your other point, I'm not sure I understand the other part of your comment. We shouldn't allow users to access rc2 or any other pre-release (alpha, beta or rc) though homebrew (or choco). The end users should only be able to install final GA releases.

Yeah, that's why I was wondering - why put two commits from two PRs, with one commit point to RC.2

karuppiah7890 commented 2 years ago

If you want to include the changes for PR 28 in this one, it shouldn't really matter. We could merge 2 PRs or just 1. If you want to include, I can close the other PR and this should be done ASAP since we are releasing at 6am tomorrow.

Done 👍 😄

vmware-tanzu / homebrew-tanzu