search

vmware-tanzu / kubeapps

A web-based UI for deploying and managing applications in Kubernetes clusters
Other
4.9k stars 708 forks source link

Add (back) trigger manual SYNC functionality for Package Repositories in the UX #5571

Open gfichtenholt opened 1 year ago

gfichtenholt commented 1 year ago

Package Repository REFRESH button has been recently removed from this screen https://user-images.githubusercontent.com/74032303/197109763-98354d95-b95a-41d1-85ab-433a7d591ce7.png

Capturing discussion from slack.

Greg F: Tried today's bits from main and the REFRESH button is gone. Short term is okay to remove it. Longer term I don't think we should remove it. It's useful where applicable. What I was originally going to say is:

  1. rename 2nd REFRESH to SYNC (or RESYNC, but I personally don't see the point of "RE"). SYNC is applicable at least for helm-direct and flux . But in order to for UX to make use of it, we need to add an API (probably to core or maybe as plugin-specific). Only after this is done, we can enable/show SYNC button
  2. It seems SYNC should also be applicable for carvel given they have a syncPeriod field in the CRD, so then question or how to trigger a reconcile manually before the next sync is done seems reasonable. Whether or not they have an answer, I don't know

Rafa C: Yes, you removed it in the “active” set of buttons. But there is a separate file with the disabled set of buttons that still contained the “refresh”. In a PR I did last week (or the week before) I removed that disabled refresh button.

Once we get an answer to whether carvel supports this, I am volunteering to add this to core API (if yes) and implement it in flux plug in.

antgamdia commented 1 year ago

This is also useful for the feature we used to have: https://github.com/vmware-tanzu/kubeapps/blob/main/site/content/docs/latest/howto/syncing-apprepository-webhook.md

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.