search

vmware-tanzu / kubeapps

A web-based UI for deploying and managing applications in Kubernetes clusters
Other
5k stars 707 forks source link

Editing and updating an app repository for an OCI app repository deletes filter #6495

Open absoludity opened 1 year ago

absoludity commented 1 year ago

Describe the bug While trying to reproduce another issue, I found that editing an existing app repository, for an oci registry, deletes the list of repositories (as in, they are not present when you edit, so when you save they're removed).

To Reproduce Steps to reproduce the behavior:

  1. Add an app repository for some OCI charts, including the list of chart repositories
  2. Save and verify everything is fine
  3. Edit the app repository

Expected behavior

List of chart repositories should still be present. But they are not and so the sync job errors (for a non VAC registry) with:

Error: Error: GET request to [https://demo.goharbor.io/v2/charts-index/manifests/latest] failed due to status [400]: {"errors":[{"code":"BAD_REQUEST","message":"bad request: invalid repository name: charts-index"}]}

Desktop (please complete the following information):

Additional context

I'm putting this as low severity as we hope to move away from requiring the list.

absoludity commented 1 year ago

Also, related to the error: the repo validation should ensure it isn't saved without the filters (if the VAC index isn't available, currently).