search

vmware-tanzu / kubeapps

A web-based UI for deploying and managing applications in Kubernetes clusters
https://kubeapps.dev
Other
4.85k stars 701 forks source link

Adding the missing externalDatabase.host and externalDatabase.port fields #7743

Open brunomedeirosdedalus opened 2 months ago

brunomedeirosdedalus commented 2 months ago

Adding the missing externalDatabase.host and externalDatabase.port fields for values.yaml

Description of the change

Benefits

Possible drawbacks

Applicable issues

Additional information

This PR adds to the values.yaml the missing 'externalDatabase.host' and 'externalDatabase'.port' fields needed to setup and external database.

vmwclabot commented 2 months ago

@brunomedeirosdedalus, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

netlify[bot] commented 2 months ago

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
Latest commit 164b81c99ca20bf9e40b32c74b8f9f9861edb072
Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/662b7454d8a39a0008c27d00
vmwclabot commented 2 months ago

@brunomedeirosdedalus, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

brunomedeirosdedalus commented 2 months ago

There is a lot room for improving here, like adding under externalDatabase, the DB username, name and so on

vmwclabot commented 1 month ago

@brunomedeirosdedalus, VMware has approved your signed contributor license agreement.