vmware-tanzu / nsx-operator

Kubernetes Operator for managing NSX network resources
Other
13 stars 20 forks source link

[cherry-pick]Improve unit-test for subnet service (#850) #911

Closed wenqiq closed 1 week ago

wenqiq commented 1 week ago

Unit test coverage increased by 3%, reaching 73.07%.

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.71%. Comparing base (b8cefee) to head (e4173c0).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/911/graphs/tree.svg?width=650&height=150&src=pr&token=R0Q6IGC2PC&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu)](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu) ```diff @@ Coverage Diff @@ ## v4.2.0 #911 +/- ## ========================================== + Coverage 71.24% 73.71% +2.46% ========================================== Files 95 109 +14 Lines 15106 15095 -11 ========================================== + Hits 10762 11127 +365 + Misses 3595 3217 -378 - Partials 749 751 +2 ``` | [Flag](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/911/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/911/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu) | `73.71% <100.00%> (+2.46%)` | :arrow_up: | | [Files with missing lines](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/911?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu) | Coverage Δ | | |---|---|---| | [pkg/nsx/services/subnet/builder.go](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/911?src=pr&el=tree&filepath=pkg%2Fnsx%2Fservices%2Fsubnet%2Fbuilder.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu#diff-cGtnL25zeC9zZXJ2aWNlcy9zdWJuZXQvYnVpbGRlci5nbw==) | `83.33% <100.00%> (ø)` | | | [pkg/nsx/services/subnet/subnet.go](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/911?src=pr&el=tree&filepath=pkg%2Fnsx%2Fservices%2Fsubnet%2Fsubnet.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu#diff-cGtnL25zeC9zZXJ2aWNlcy9zdWJuZXQvc3VibmV0Lmdv) | `65.65% <100.00%> (+30.49%)` | :arrow_up: | ... and [29 files with indirect coverage changes](https://app.codecov.io/gh/vmware-tanzu/nsx-operator/pull/911/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vmware-tanzu)

🚨 Try these New Features:

zhengxiexie commented 1 week ago

/e2e

zhengxiexie commented 1 week ago

/e2e