vmware-tanzu / package-for-kubeapps

This repo will house the carvel tooling specific configuration and templating for a deployment of Kubeapps (https://github.com/vmware-tanzu/kubeapps) that will be leveraged by TCE
Apache License 2.0
5 stars 0 forks source link

Update package.yml to include sha of imgpkgbundle rather than tag #8

Closed absoludity closed 2 years ago

absoludity commented 2 years ago

Currently the script creates the package.yml referencing the imgpkgBundle via the published tag. Not sure if this is ideally meant to be a sha (have seen examples of such, eg https://github.com/vmware-tanzu/package-for-kpack/releases/download/v0.5.2/package.yaml ).

If so, need to update to push the image first before templating the package.yml.

absoludity commented 2 years ago

Actually, based on https://carvel.dev/kapp-controller/docs/v0.36.1/app-spec/#docs (which the Package.yaml refers to), the imagePackageBundle.image can use a tag or a digest reference (both supported, and the example uses a tag). So closing this one for now :)