search

vmware-tanzu / pinniped

Pinniped is the easy, secure way to log in to your Kubernetes clusters.
https://pinniped.dev
Apache License 2.0
566 stars 66 forks source link

WIP: GitHub identity provider (do not merge) #1906

Closed benjaminapetersen closed 6 months ago

benjaminapetersen commented 7 months ago

Opened as WIP.

Keeping our long running github_identity_provider branch open as a PR against main so we can see how CI is doing as we merge smaller feature branches into it (we do have CI setup on this branch as it receives PRs, but there is also value in seeing status against main as we work).

Release note:

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 59.58055% with 424 lines in your changes are missing coverage. Please review.

Project coverage is 29.91%. Comparing base (56d7dee) to head (d34f297).

Files Patch % Lines
...ioned/typed/idp/v1alpha1/githubidentityprovider.go 0.00% 107 Missing :warning:
test/testlib/client.go 0.00% 79 Missing :warning:
...s/supervisor/idp/v1alpha1/zz_generated.deepcopy.go 63.39% 53 Missing and 3 partials :warning:
...d/idp/v1alpha1/fake/fake_githubidentityprovider.go 32.39% 46 Missing and 2 partials :warning:
...ternal/testutil/oidctestutil/testgithubprovider.go 43.24% 42 Missing :warning:
internal/controller/utils.go 0.00% 27 Missing :warning:
...rovider/resolvedgithub/resolved_github_provider.go 45.16% 16 Missing and 1 partial :warning:
internal/testutil/testidplister/testidplister.go 65.62% 10 Missing and 1 partial :warning:
...g/githubupstreamwatcher/github_upstream_watcher.go 96.88% 7 Missing and 3 partials :warning:
...nalversions/idp/v1alpha1/githubidentityprovider.go 61.90% 6 Missing and 2 partials :warning:
... and 6 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1906 +/- ## ========================================== + Coverage 29.46% 29.91% +0.45% ========================================== Files 350 357 +7 Lines 58538 59499 +961 ========================================== + Hits 17246 17797 +551 - Misses 40777 41173 +396 - Partials 515 529 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joshuatcasey commented 6 months ago

Closing this, let's derisk our long-running branch by continually merging main into github_identity_provider