Closed cfryanr closed 4 months ago
Attention: Patch coverage is 86.51163%
with 29 lines
in your changes are missing coverage. Please review.
Project coverage is 38.45%. Comparing base (
5fe94c4
) to head (57a07a4
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Although this is covered by integration tests, it probably also deserves some manual testing before merge.
This PR adds a new configuration option to
OIDCClient
resources to allow the ID tokens issued by authcode flows and refresh flows to have a custom lifetime, within certain reasonable limits of min/max allowed lifetimes. See the new field introduced intypes_oidcclient.go.tmpl
in the diffs of this PR.Note that this PR borrows heavily from the proof-of-concept PR https://github.com/vmware-tanzu/pinniped/pull/1857. The difference is that this PR is intended to be production-quality and to be eventually merged. This PR does not include anything from the POC PR about adjusting token lifetimes for sessions started using GitHub PATs, but that could be added later after this PR is merged, if desired.
Release note: