vmware-tanzu / pinniped

Pinniped is the easy, secure way to log in to your Kubernetes clusters.
https://pinniped.dev
Apache License 2.0
541 stars 65 forks source link

Bump libs to K8s 1.30 #1921

Closed joshuatcasey closed 4 months ago

joshuatcasey commented 4 months ago

Bump libs to K8s 1.30.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.45%. Comparing base (b99da0c) to head (9d21bca).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1921 +/- ## ========================================== - Coverage 38.45% 29.45% -9.00% ========================================== Files 350 350 Lines 44680 58538 +13858 ========================================== + Hits 17182 17244 +62 - Misses 26983 40779 +13796 Partials 515 515 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cfryanr commented 4 months ago

I added 1.30 to the verify-codegen CI job and it failed with this error on the 1.30 codegen:

generating API-related code for our public API groups...
gen-api > ERROR: generate-groups.sh has been removed.
gen-api > ERROR: Please use k8s.io/code-generator/kube_codegen.sh instead.

So that's another item on the TODO list for this PR.

Reverting the commit (https://github.com/vmware-tanzu/pinniped-ci/commit/a7f342b81ca625d9ad2fea4ca38afb6ada7055e4) for now, but we need to figure out how to bring it back.

Update: I think I fixed this in the most recent commits.

cfryanr commented 4 months ago

This PR is also failing this integration test in CI about 50% of the time. This needs investigation during this PR effort.

=== FAIL: pkgname TestIntegrationParallel/TestLeaderElection_Parallel/clients_handle_leader_election_restart_correctly (30.02s)
    leaderelection_test.go:207: lease leader-election-k7tln-integration-test-tfp89/leader-election-k7tln - current leader identity: leader-election-client-rxc9w, valid leader identities: [leader-election-client-9ltzb leader-election-client-dvhtm leader-election-client-rxc9w leader-election-client-v4sgc]
    leaderelection_test.go:207: lease leader-election-k7tln-integration-test-tfp89/leader-election-k7tln - current leader identity: leader-election-client-rxc9w, valid leader identities: [leader-election-client-9ltzb leader-election-client-dvhtm leader-election-client-rxc9w leader-election-client-v4sgc]
    leaderelection_test.go:200: lease leader-election-k7tln-integration-test-tfp89/leader-election-k7tln does not exist
    leaderelection_test.go:200: lease leader-election-k7tln-integration-test-tfp89/leader-election-k7tln does not exist
    leaderelection_test.go:200: lease leader-election-k7tln-integration-test-tfp89/leader-election-k7tln does not exist
    leaderelection_test.go:207: lease leader-election-k7tln-integration-test-tfp89/leader-election-k7tln - current leader identity: leader-election-client-rxc9w, valid leader identities: [leader-election-client-9ltzb leader-election-client-dvhtm leader-election-client-rxc9w leader-election-client-v4sgc]
    leaderelection_test.go:61: 
            Error Trace:    /work/test/integration/leaderelection_test.go:307
                                        /work/test/integration/leaderelection_test.go:61
            Error:          Should be zero, but was 1
            Test:           TestIntegrationParallel/TestLeaderElection_Parallel/clients_handle_leader_election_restart_correctly
        --- FAIL: TestIntegrationParallel/TestLeaderElection_Parallel/clients_handle_leader_election_restart_correctly (30.02s)

=== FAIL: pkgname TestIntegrationParallel/TestLeaderElection_Parallel (271.17s)
    leaderelection_test.go:41: running leader election client tests with 4 clients: [leader-election-client-9ltzb leader-election-client-dvhtm leader-election-client-rxc9w leader-election-client-v4sgc]
    client.go:811: cleaning up test namespace leader-election-k7tln-integration-test-tfp89
    --- FAIL: TestIntegrationParallel/TestLeaderElection_Parallel (271.17s)

Update: I added a potential fix for this problem to this PR. See below.

joshuatcasey commented 4 months ago

lgtm as of 9d21bca but I can't approve since I'm the PR author.