Closed joshuatcasey closed 3 months ago
Attention: Patch coverage is 96.89441%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 29.50%. Comparing base (
d7849c7
) to head (a64cf4a
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We want this feature in the Concierge too, right? So far, this PR seems to only focus on the Supervisor.
I feel like we should figure out if we can integration test this feature. There are already integrations tests about which ciphers we allow for both FIPS builds and non-FIPS builds. Although this might be tricky because the ConfigMap is only ready when the pods are restarted, so the test might need to restart the pods (similar to the TestPodShutdown_Disruptive
).
Force-pushed to 2975d2a0
just to keep ahead of main@545df755
, no PR feedback was addressed in that update.
Force-pushed to 40519bd1
to keep ahead of main and to resolve the godoc feedback above.
We want this feature in the Concierge too, right? So far, this PR seems to only focus on the Supervisor.
Yes. Will update with this feature exposed through the Concierge.
EDIT: pushed
Let's use these terms:
userConfiguredCiphersAllowList
for the ciphers that the user specifieshardcodedCiphers
for the ciphers that are hardcoded within PinnipedTake a look at making sure that FIPS code is minimal and business logic should be in common code (FIPS and non-FIPS).
Closing in favor of #1952
Allow user-limited TLS ciphers for TLS1.2
Resolves #1605