search

vmware-tanzu / pinniped

Pinniped is the easy, secure way to log in to your Kubernetes clusters.
https://pinniped.dev
Apache License 2.0
566 stars 66 forks source link

IDP Discovery Test improvement: Add OIDC, LDAP #1930

Closed benjaminapetersen closed 6 months ago

benjaminapetersen commented 6 months ago

Adds OIDC & LDAP to the IDP Discovery Test. ActiveDirectory not included (yet) as it is not always available in our test envs. Targeted at the github_identty_provider branch as this is where the initial test commit exists.

Release note:

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.03%. Comparing base (9a21cb9) to head (0056764). Report is 1 commits behind head on github_identity_provider.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## github_identity_provider #1930 +/- ## ========================================================= Coverage 39.03% 39.03% ========================================================= Files 356 356 Lines 45472 45472 ========================================================= Hits 17751 17751 Misses 27192 27192 Partials 529 529 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joshuatcasey commented 6 months ago

Approved but I think the AD-enabled integration tests are failing

benjaminapetersen commented 6 months ago

👀 to see whats up with that. 👍