CLI also skips authcode prompt when PINNIPED_SKIP_PRINT_LOGIN_URL=true

vmware-tanzu / pinniped

Pinniped is the easy, secure way to log in to your Kubernetes clusters.

https://pinniped.dev

Apache License 2.0

541 stars 65 forks source link

CLI also skips authcode prompt when PINNIPED_SKIP_PRINT_LOGIN_URL=true #1938

Closed cfryanr closed 4 months ago

cfryanr commented 4 months ago

Follow-up to https://github.com/vmware-tanzu/pinniped/pull/1897 to make the CLI also skip printing the authcode prompt when PINNIPED_SKIP_PRINT_LOGIN_URL=true. This allows the use of PINNIPED_SKIP_PRINT_LOGIN_URL=true with the Pinniped Supervisor (and other OIDC providers who use response_mode=form_post), which would have prompted for the authcode before this PR, potentially corrupting a console-based UI like k9s.

Release note:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.39%. Comparing base (c494add) to head (c86a615).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1938 +/- ## ======================================= Coverage 29.39% 29.39% ======================================= Files 350 350 Lines 58518 58513 -5 ======================================= - Hits 17203 17202 -1 + Misses 40800 40797 -3 + Partials 515 514 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.