search

vmware-tanzu / pinniped

Pinniped is the easy, secure way to log in to your Kubernetes clusters.
https://pinniped.dev
Apache License 2.0
541 stars 65 forks source link

Bump golangci-lint to 1.58.1 #1939

Closed joshuatcasey closed 3 months ago

joshuatcasey commented 4 months ago

Bump golangci-lint to 1.58.1.

This will require a change in CI to bump golangci-lint.

Adds ./hack/module lint-in-docker which runs golangci-lint with a repeatable version number.

joshuatcasey commented 4 months ago

Marking as draft while I consider adding some new linters.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 46.42857% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 29.39%. Comparing base (1e6b8a0) to head (5568372).

Files Patch % Lines
internal/controller/utils.go 0.00% 4 Missing :warning:
internal/concierge/apiserver/apiserver.go 0.00% 2 Missing :warning:
internal/supervisor/server/server.go 0.00% 2 Missing :warning:
test/testlib/activedirectory.go 0.00% 2 Missing :warning:
test/testlib/assertions.go 33.33% 2 Missing :warning:
internal/concierge/server/server.go 0.00% 0 Missing and 1 partial :warning:
internal/controllerlib/filter.go 0.00% 0 Missing and 1 partial :warning:
internal/supervisor/apiserver/apiserver.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1939 +/- ## ========================================== - Coverage 29.39% 29.39% -0.01% ========================================== Files 350 349 -1 Lines 58513 58484 -29 ========================================== - Hits 17201 17190 -11 + Misses 40798 40779 -19 - Partials 514 515 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joshuatcasey commented 3 months ago

This is blocked on CI work to upgrade the linter to 1.58.1