search

vmware-tanzu / pinniped

Pinniped is the easy, secure way to log in to your Kubernetes clusters.
https://pinniped.dev
Apache License 2.0
541 stars 65 forks source link

Use plog.Logger instead of logr.Logger wherever possible #1949

Closed joshuatcasey closed 2 months ago

joshuatcasey commented 3 months ago

Use plog.Logger instead of logr.Logger wherever possible

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 80.20833% with 19 lines in your changes missing coverage. Please review.

Project coverage is 30.59%. Comparing base (247ac10) to head (011d6ba).

Files Patch % Lines
internal/plog/testing.go 53.84% 6 Missing :warning:
pkg/oidcclient/login.go 87.09% 4 Missing :warning:
internal/controllermanager/prepare_controllers.go 0.00% 3 Missing :warning:
cmd/pinniped/cmd/oidc_client_options.go 0.00% 2 Missing :warning:
cmd/pinniped/cmd/login_oidc.go 66.66% 1 Missing :warning:
...ntroller/impersonatorconfig/impersonator_config.go 96.55% 1 Missing :warning:
internal/controller/kubecertagent/kubecertagent.go 0.00% 1 Missing :warning:
...onfig/oidcupstreamwatcher/oidc_upstream_watcher.go 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1949 +/- ## ========================================== - Coverage 30.61% 30.59% -0.02% ========================================== Files 363 363 Lines 60492 60516 +24 ========================================== - Hits 18518 18516 -2 - Misses 41440 41467 +27 + Partials 534 533 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.