Resolve remaining GitHub todos

[cfryanr]

Release note:

NONE

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 49.63504% with 69 lines in your changes are missing coverage. Please review.

Project coverage is 30.62%. Comparing base (38a90fa) to head (58b4ecc). Report is 1 commits behind head on github_identity_provider.

Files	Patch %	Lines
test/testlib/browsertest/browsertest.go	0.00%	41 Missing :warning:
...vedprovider/resolvedoidc/resolved_oidc_provider.go	4.54%	21 Missing :warning:
...entityprovider/mockupstreamoidcidentityprovider.go	0.00%	3 Missing :warning:
internal/upstreamldap/upstreamldap.go	75.00%	2 Missing :warning:
...tiondomain/downstreamsession/downstream_session.go	0.00%	1 Missing :warning:
...vedprovider/resolvedldap/resolved_ldap_provider.go	83.33%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## github_identity_provider #1976 +/- ## ============================================================ + Coverage 30.60% 30.62% +0.01% ============================================================ Files 362 363 +1 Lines 60383 60461 +78 ============================================================ + Hits 18481 18515 +34 - Misses 41368 41411 +43 - Partials 534 535 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.