search

vmware-tanzu / pinniped

Pinniped is the easy, secure way to log in to your Kubernetes clusters.
https://pinniped.dev
Apache License 2.0
527 stars 64 forks source link

handle another github login interstitial page #1983

Closed cfryanr closed 1 month ago

cfryanr commented 1 month ago

Handle another page that can happen during github login in integration tests.

The page looks like this: image

Tests that see this page should try to click the "skip" link to move past it.

Release note:

NONE
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 30.60%. Comparing base (e9fa98e) to head (1fe6f2e).

Files Patch % Lines
test/testlib/browsertest/browsertest.go 0.00% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1983 +/- ## ========================================== - Coverage 30.61% 30.60% -0.02% ========================================== Files 363 363 Lines 60481 60492 +11 ========================================== - Hits 18518 18514 -4 - Misses 41429 41443 +14 - Partials 534 535 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.