vmware-tanzu / pinniped

Pinniped is the easy, secure way to log in to your Kubernetes clusters.
https://pinniped.dev
Apache License 2.0
566 stars 66 forks source link

remove unnecessary warning log message #2010

Closed cfryanr closed 3 months ago

cfryanr commented 3 months ago

This message is not needed because the IDP chooser page will take care of the case where a browser-based authorization flow did not request any specific IDP. For browserless flows (only allowed for the pinniped-cli client), the client must request a specific IDP (except in backwards-compatibility mode) because there is no browser in which to show the IDP chooser page. Failing to request a specific IDP in a browserless flow will result in a helpful error message being returned.

Release note:

NONE
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 30.67%. Comparing base (dd80627) to head (e5cfa52).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2010 +/- ## ========================================== - Coverage 30.69% 30.67% -0.03% ========================================== Files 365 365 Lines 60616 60594 -22 ========================================== - Hits 18609 18589 -20 + Misses 41470 41469 -1 + Partials 537 536 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ashish-amarnath commented 3 months ago

The CI job is failing, but unlikely it is related to this change.

cfryanr commented 3 months ago

I'm not sure what is causing these integration test failure flakes. They all look the same, which is a dial tcp i/o timeout while trying to make a Kubernetes API call to a remote Kind cluster. Each of the four failed jobs encountered this problem only once (out of hundreds or maybe thousands of API calls made by the whole integration test suite), and each failed on a different Kubernetes API.

This is strange because it seems to be happening a lot lately, but did not happen often previously.