Closed cfryanr closed 3 months ago
Attention: Patch coverage is 98.82353%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 30.73%. Comparing base (
6b722a1
) to head (a2be4b7
).
Files | Patch % | Lines |
---|---|---|
...ler/authenticator/jwtcachefiller/jwtcachefiller.go | 97.36% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
When the spec of a JWTAuthenticator or WebhookAuthenticator changes, and if the resource goes from being valid to being invalid, then that authenticator should not be used anymore. This PR removes it from the in-memory cache so it cannot be used during auth anymore.
This PR also reduces how often the WebhookAuthenticators are revalidated. When the spec has not changed since it was previously validated, then skip performing validations and leave it in the in-memory cache for usage during auth.
These changes also have the side benefit of making the code for controller for WebhookAuthenticators and the controller for JWTAuthenticator more similar/consistent.
Release note: