search

vmware-tanzu / pinniped

Pinniped is the easy, secure way to log in to your Kubernetes clusters.
https://pinniped.dev
Apache License 2.0
566 stars 66 forks source link

OIDC/LDAP/AD IDPs should use unknown condition status #2034

Closed joshuatcasey closed 2 months ago

joshuatcasey commented 2 months ago

OIDC/LDAP/AD IDPs should report conditions with status Unknown when it cannot perform a validation.

LDAP should report condition LDAPConnectionValid with status Unknown if either condition BindSecretValid or TLSConfigurationValid are invalid.

Active Directory should report conditions LDAPConnectionValid and SearchBaseFound with status Unknown if either condition BindSecretValid or TLSConfigurationValid are invalid.

Fixes #2031

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 44.32990% with 54 lines in your changes missing coverage. Please review.

Project coverage is 31.17%. Comparing base (fbbec50) to head (c1328d9).

Files Patch % Lines
test/testlib/client.go 0.00% 54 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2034 +/- ## ========================================== - Coverage 31.18% 31.17% -0.02% ========================================== Files 366 366 Lines 61119 61174 +55 ========================================== + Hits 19061 19070 +9 - Misses 41525 41571 +46 Partials 533 533 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joshuatcasey commented 2 months ago

Merge after #2036