search

vmware-tanzu / pinniped

Pinniped is the easy, secure way to log in to your Kubernetes clusters.
https://pinniped.dev
Apache License 2.0
566 stars 66 forks source link

Publish Pinniped CLI to Krew #990

Open aslafy-z opened 2 years ago

aslafy-z commented 2 years ago

Is your feature request related to a problem? Please describe. Users don't know how to add things to PATH.

Describe the solution you'd like Publish Pinniped as a Kubectl plugin installable with Krew so they can just do kubectl krew install pinniped.

Describe alternatives you've considered They can download the binary and put it into the path, or depending on the os, use, aur, brew or other. A "curl|bash" flow could also do the thing but I don't really like that.

Are you considering submitting a PR for this feature? No

Additional context See https://krew.sigs.k8s.io/docs/developer-guide/distributing-with-krew/

enj commented 2 years ago

I think this is technically possible if we publish the pinniped CLI as kubectl-pinniped to krew. We would need to enhance the get kubeconfig command detect this case so that it correctly uses the plugin mechanism to invoke the exec plugin (possibly in a way that figures out the correct path for kubectl?). We may also want to (dynamically?) update the install hint to handle this case?

enj commented 2 years ago

Related discussion on the Kubernetes slack.