search

vmware-tanzu / tanzu-cli

The Tanzu Core CLI project provides the core functionality of the Tanzu CLI. The CLI is based on a plugin architecture where CLI command functionality can be delivered through independently developed plugin binaries
Apache License 2.0
35 stars 22 forks source link

Digitally sign binary releases #554

Closed taylor-madeak closed 11 months ago

taylor-madeak commented 11 months ago

Tanzu Core CLI v0.28.0 (buildDate: 2023-01-20) was digitally signed by VMware, Inc., allowing us to whitelist it by certificate (you VMware folks should be familiar with Carbon Black App Control). I don't know the full history of how this project came to be, but somewhere in that process it seems that codesigning of binary releases was dropped.

This is a feature request to add codesigning binary releases back to your release train so that we don't have to whitelist by file hash every time we want to upgrade our CLI utility.

marckhouzam commented 11 months ago

@taylor-madeak What OS are talking about?

taylor-madeak commented 11 months ago

@marckhouzam Primarily Windows x64.

marckhouzam commented 11 months ago

Right. The Mac binaries are signed but the windows are not.

taylor-madeak commented 11 months ago

Probably because macOS is a whole lot more strict about that than Windows, I imagine. That doesn't take into account corporate environments where application whitelisting security software is used, though.

I put the request out there. Hopefully it's not too big of a lift to get signed Windows binary releases back on offer. :)

taylor-madeak commented 11 months ago

Just saw that the 1.1.0-rc.0 release Windows binary is now signed. Thank you @vuil!

taylor-madeak commented 11 months ago

I think this can be closed now. The v1.1.0 release for Windows x64 is digitally signed, which solves my problem.