Closed vuil closed 8 months ago
I assume that the explanation: "An upcoming change will provide more contextual information to the plugin on how it's commands are invoked by the Tanzu CLI. Until then this remapping functionality is best limited to scenarios of relocating without command group renaming, or ones that only involve minor and non-surprising renames of the command group for the plugin's commands."
means that we have to accept that the help text shows the plugin name and not the invokeAs
name?
I assume that the explanation: "An upcoming change will provide more contextual information to the plugin on how it's commands are invoked by the Tanzu CLI. Until then this remapping functionality is best limited to scenarios of relocating without command group renaming, or ones that only involve minor and non-surprising renames of the command group for the plugin's commands."
means that we have to accept that the help text shows the plugin name and not the
invokeAs
name?
It is a rough edge, but I am inclined keep this and address improvement as a followup. Partly because changes will likely involve additiona runtime changes, and when made should hopefully be thorough enough for plugin code (not just the help text) can also account for the mapping.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Update unit tests. Additionally
Assuming k8s-targetted plugin
apps
is installedBuild and install additional plugin with different PluginDescriptor ... 1)
verified that the apps cmd node (invoked via tanzu apps ... ) is replaced with that for the new plugin. Similarly for
tanzu kubernetes app
, only when an active CLI context is of type tanzu2)
verified that the apps cmd node (invoked via tanzu apps ... ) is unconditionally replaced with that for the new plugin. Similarly for
tanzu kubernetes app
3)
verified that the appsalt cmd node (invoked via tanzu appsalt ... ) is introduced. This is not a recommended scenario as the presence of the original apps command group could lead to UX artifacts like duplicated aliases warning.
Release note
Additional information
Special notes for your reviewer