search

vmware-tanzu / tanzu-framework

Tanzu Framework provides a set of building blocks to build atop of the Tanzu platform and leverages Carvel packaging and plugins to provide users with a much stronger, more integrated experience than the loose coupling and stand-alone commands of the previous generation of tools.
Apache License 2.0
196 stars 193 forks source link

spike: Add FeatureGate environment variables to Windows YTT #1296

Open jayunit100 opened 2 years ago

jayunit100 commented 2 years ago

Bug description

Right now, we don't add featureGates to the YTT for windows. But for things like hostProcess we'd like users to be able to enable them.

Affected product area (please put an X in all that apply)

Expected behavior

Users can enable kubeadm flags for windows nodes easily.

Steps to reproduce the bug

Version (include the SHA if the version is not obvious)

Environment where the bug was observed (cloud, OS, etc)

Relevant Debug Output (Logs, manifests, etc)

jayunit100 commented 2 years ago

@weiwenli97 can you make sure that @knabben accomodates this in his ongoing work with @vrabbi '

ACTUALLY sounds like wenli wants to do this :) so, wenli please make a small change here and merge it independently of amims work.

jayunit100 commented 2 years ago

/assign @weiwenli97

knabben commented 2 years ago

I think we need to add in the official TKG documentation for 1.5. MAybe we can start with a confluence page, and sync with Paul Spinrad to write the official docs.