vmware-tanzu / tanzu-framework

Tanzu Framework provides a set of building blocks to build atop of the Tanzu platform and leverages Carvel packaging and plugins to provide users with a much stronger, more integrated experience than the loose coupling and stand-alone commands of the previous generation of tools.
Apache License 2.0
195 stars 192 forks source link

Check for existing Tanzu Builder and use if there #4641

Closed codegold79 closed 1 year ago

codegold79 commented 1 year ago

What this PR does / why we need it

Although it's not the recommended way to download and use Tanzu CLI Plugin Builder, this PR provides a direct way to obtain the builder binary and use it. It bypasses using Tanzu CLI altogether.

Which issue(s) this PR fixes

Fixes #4640

Describe testing done for PR

Release note

Additional information

Special notes for your reviewer

codecov[bot] commented 1 year ago

Codecov Report

Merging #4641 (9c63c74) into main (7fa2b72) will increase coverage by 0.26%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4641      +/-   ##
==========================================
+ Coverage   75.06%   75.33%   +0.26%     
==========================================
  Files          21       21              
  Lines        1199     1212      +13     
==========================================
+ Hits          900      913      +13     
  Misses        249      249              
  Partials       50       50              

see 2 files with indirect coverage changes

codegold79 commented 1 year ago

Sorry, @avi-08, I should've put my latest change into a separate commit where I put the tanzu-builder into a new directory, tanzu-cli. I wasn't thinking and just did a rebase. But should be easy enough to re-review.