search

vmware-tanzu / tanzu-framework

Tanzu Framework provides a set of building blocks to build atop of the Tanzu platform and leverages Carvel packaging and plugins to provide users with a much stronger, more integrated experience than the loose coupling and stand-alone commands of the previous generation of tools.
Apache License 2.0
195 stars 192 forks source link

should "tanzu package install" and update/delete command show progress info? #781

Open cppforlife opened 3 years ago

cppforlife commented 3 years ago

Describe the feature request

currently tanzu package install (and friends) just sits there and does not indicate whats happening to the PackageInstall. now PackageInstall itself does not have much "live" status information; however, associated App CR (by the same name) does have "live" status with output for fetch/template/deploy steps. deploy step is the most interesting one i guess which includes output from kapp.

it might be a good idea to show this info to the user and "live" update it.

Describe alternatives you've considered

Affected product area (please put an X in all that apply)

Additional context

vijaykatam commented 3 years ago

We should show status. Wondering if this is a regression. PkgInstall object is queried for updates to status resource. Are you suggesting to also query App CR? Additionally could you include what you are current seeing?

maralavi commented 3 years ago

Thanks for opening the issue @cppforlife and sorry for the issues. However, I am able to see the progress being shown in latest code of tanzu-framework main:

tanzu package install test-pkg --package-name pkg.test.carvel.dev --version 1.0.0 -n test-ns --create-namespace
/ Installing package 'pkg.test.carvel.dev'
| Creating namespace 'test-ns'
- Getting package metadata for 'pkg.test.carvel.dev'
| Creating service account 'test-pkg-test-ns-sa'
| Creating cluster admin role 'test-pkg-test-ns-cluster-role'
| Creating cluster role binding 'test-pkg-test-ns-cluster-rolebinding'
\ Creating package resource
\ Resource install status: Reconciling

 Added installed package 'test-pkg' in namespace 'test-ns'
cppforlife commented 3 years ago

does not have much "live" status information

sorry, by this i meant direct live kapp deploy output that's being continuously updated on App CR. was not talking about conditions.

vijaykatam commented 3 years ago

direct live kapp deploy output that's being continuously updated on App CR

Which field is this? Would it make sense to mirror that on PackageInstall since we consider App CR as internal to kapp-controller?