vmware-tanzu / tanzu-framework

Tanzu Framework provides a set of building blocks to build atop of the Tanzu platform and leverages Carvel packaging and plugins to provide users with a much stronger, more integrated experience than the loose coupling and stand-alone commands of the previous generation of tools.
Apache License 2.0
196 stars 193 forks source link

Name clusterconfig files based on the specified cluster name rather than a random string #842

Open joshrosso opened 3 years ago

joshrosso commented 3 years ago

This feature request came from @djschny in the community-edition project

Bug Report

The documentation says the management cluster configuration file should be found as follows:

~/.config/tanzu/tkg/clusterconfigs/.yaml where is either the name you specified in the installer interface or else the randomly generated name if you didn’t specify a name.

However even though a cluster name was provided and verified in the config file and other places, the name of the file is a randomly generated name.

Expected Behavior

The configuration file name to match the name of the management cluster.

Steps to Reproduce the Bug

Create a management cluster using the Installer UI and give it a name.

Screenshots or additional information and context

$ tanzu management-cluster get
  NAME             NAMESPACE   STATUS   CONTROLPLANE  WORKERS  KUBERNETES        ROLES       
  my-mgmt-cluster  tkg-system  running  1/1           1/1      v1.21.2+vmware.1  management  

Details:

NAME                                                                READY  SEVERITY  REASON  SINCE  MESSAGE
/my-mgmt-cluster                                                    True                     51m           
├─ClusterInfrastructure - DockerCluster/my-mgmt-cluster             True                     52m           
├─ControlPlane - KubeadmControlPlane/my-mgmt-cluster-control-plane  True                     51m           
│ └─Machine/my-mgmt-cluster-control-plane-g8jfp                     True                     51m           
└─Workers                                                                                                  
  └─MachineDeployment/my-mgmt-cluster-md-0                                                                 
    └─Machine/my-mgmt-cluster-md-0-5bbb796786-rkl69                 True                     51m           

Providers:

  NAMESPACE                          NAME                   TYPE                    PROVIDERNAME  VERSION  WATCHNAMESPACE  
  capd-system                        infrastructure-docker  InfrastructureProvider  docker        v0.3.23                  
  capi-kubeadm-bootstrap-system      bootstrap-kubeadm      BootstrapProvider       kubeadm       v0.3.23                  
  capi-kubeadm-control-plane-system  control-plane-kubeadm  ControlPlaneProvider    kubeadm       v0.3.23                  
  capi-system                        cluster-api            CoreProvider            cluster-api   v0.3.23                  
$ ls ~/.config/tanzu/tkg/clusterconfigs
a6zgiz6zta.yaml

Environment Details

Diagnostics and log bundle

vuil commented 2 years ago

@miclettej this looks to be a dupe of another issue?