vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.54k stars 1.38k forks source link

restic-helper-image needs to be customizable for local container registries #3033

Open AhmedBenAbid opened 3 years ago

AhmedBenAbid commented 3 years ago

Describe the problem/challenge you have Hello, We are using PKS as a Kubernetes installer on vSphere in a air-gapped environnement, so all Docker images need to be imported to a local registry. The vSphere version we're currently using doesn't support Volume Snaphot, so we choose Restic integration for PV backups.

We are using the CLI to install the velero, which allow us to choose velero's and restic's images, but not the restic-restore-helper image (which can be configured later using a ConfigMap) Also, we cannot choose hostPath path on installation

Describe the solution you'd like It would be practical to add these two parameters as cli flags: --restic-helper-image --restic-hostpath

Environment:

Thank you for your attention.

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

nrb commented 3 years ago

I think we can reliably detect TKGI's preferred restic hostpath with information provided in https://github.com/vmware-tanzu/velero/issues/2767. The helper image would definitely be useful to add, though.

nrb commented 3 years ago

@carlisia Can we figure out how to do this with the Carvel work? I'd rather not add more options to velero install, but I think these options should be exposed.