Plugins param for velero installation should allow surrounding comma with blank spaces

[danfengliu]

What steps did you take and what happened: [A clear and concise description of what the bug is, and what commands you ran.)

When install velero with param plugins like this: --plugins harbor-repo.vmware.com/harbor-ci/velero/velero-plugin-for-aws:v1.2.0, vsphereveleroplugin/velero-plugin-for-vsphere:v1.1.1

Got error like this: BackupStorageLocation/default: created VolumeSnapshotLocation/default: attempting to create resource VolumeSnapshotLocation/default: attempting to create resource client VolumeSnapshotLocation/default: created Deployment/velero: attempting to create resource Deployment/velero: attempting to create resource client An error occurred:

Error installing Velero. Use kubectl logs deploy/velero -n velero to check the deploy logs: Error creating resource Deployment/velero: Deployment.apps "velero" is invalid: [spec.template.spec.initContainers[1].name: Required value, spec.template.spec.initContainers[1].image: Required value]

What did you expect to happen: Installation should be success.

The output of the following commands will help us better understand what's going on: (Pasting long output into a GitHub gist or other pastebin is fine.)

• kubectl logs deployment/velero -n velero
• velero backup describe <backupname> or kubectl get backup/<backupname> -n velero -o yaml
• velero backup logs <backupname>
• velero restore describe <restorename> or kubectl get restore/<restorename> -n velero -o yaml
• velero restore logs <restorename>

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

• Velero version (use velero version):
• Velero features (use velero client config get features):
• Kubernetes version (use kubectl version):
• Kubernetes installer & version:
• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

• :+1: for "I would like to see this bug fixed as soon as possible"
• :-1: for "There are more important bugs to focus on right now"

[reasonerjt]

So either the CLI trim the input or it may fail earlier and more explicitly.

[reasonerjt]

@danfengliu in this case you should quote the list like "harbor-repo.vmware.com/harbor-ci/velero/velero-plugin-for-aws:v1.2.0, vsphereveleroplugin/velero-plugin-for-vsphere:v1.1.1" otherwise the space will confuse the shell and CLI thinks it's another param.

Keeping this open to check why there's no more explicit error.

[danfengliu]

@reasonerjt yes, it's should be quoted. After quoting, it's still not an acceptable param for velero CLI, the message is more clearer, but I think it's better this format should be accepted as an input param.

Error installing Velero. Use kubectl logs deploy/velero -n velero to check the deploy logs: Error creating resource Deployment/velero: Deployment.apps "velero" is invalid: spec.template.spec.initContainers[1].name: Invalid value: " vsphereveleroplugin-velero-plugin-for-vsphere": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc', regex used for validation is 'a-z0-9?')