vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.66k stars 1.4k forks source link

`velero backup download` command could not download other resources except BackupContents #5376

Open qiuming-best opened 2 years ago

qiuming-best commented 2 years ago

What steps did you take and what happened: [A clear and concise description of what the bug is, and what commands you ran.) For command velero backup download we can only download BackupContents kind of resources, it needs to add a new flag to specify other kinds of resources instead of the default BackupContents here is the code

What did you expect to happen:

The following information will help us better understand what's going on:

If you are using velero v1.7.0+:
Please use velero debug --backup <backupname> --restore <restorename> to generate the support bundle, and attach to this issue, more options please refer to velero debug --help

If you are using earlier versions:
Please provide the output of the following commands (Pasting long output into a GitHub gist or other pastebin is fine.)

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

cleverhu commented 2 years ago

I'd like to improve this, can this issue be assigned to me?

cleverhu commented 2 years ago

@qiuming-best I have pulled a request for this. /PTAL. Thanks.

qiuming-best commented 2 years ago

@cleverhu thanks for your contribution

Lyndon-Li commented 1 year ago

Let's brainstorm the scenarios that other kinds are required to be downloaded and what are the exact kinds required to be downloaded