vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.79k stars 1.41k forks source link

CSI plugin should not drop PVC when restorePVs is false #6040

Closed blackpiglet closed 1 year ago

blackpiglet commented 1 year ago

What steps did you take and what happened:

PR https://github.com/vmware-tanzu/velero-plugin-for-csi/pull/127 makes the CSI plugin also honor the restorePVs flag setting in velero's restore, but the change makes PVC skipped. This makes the pods pending after restoration.

What did you expect to happen: PVC should be restored but without the data.

The following information will help us better understand what's going on:

If you are using velero v1.7.0+:
Please use velero debug --backup <backupname> --restore <restorename> to generate the support bundle, and attach to this issue, more options please refer to velero debug --help

If you are using earlier versions:
Please provide the output of the following commands (Pasting long output into a GitHub gist or other pastebin is fine.)

Anything else you would like to add:

Environment:

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

reasonerjt commented 1 year ago

It's a dup of #6056

Closing this one and track the status via #6056