Closed shubham-pampattiwar closed 3 months ago
@shubham-pampattiwar Could help to address the comments so that we can further review and merge it? To meet FC, we hope this could be merged by the end of this week or early next week.
@Lyndon-Li addressed PR comments.
Attention: Patch coverage is 73.85621%
with 40 lines
in your changes are missing coverage. Please review.
Project coverage is 58.66%. Comparing base (
22b9465
) to head (8d2bef2
). Report is 24 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@shubham-pampattiwar Two more following up comments from me and @blackpiglet, see if you could address it. Basically, we suggest to avoid generating a dynamic client inside the helper, but get it from the backup as an input parameter and then call the existing function in util/pvc_pv.go.
@shubham-pampattiwar We also see the code coverage has dropped by 0.24% due to this PR, could you help to add some more test case?
@Lyndon-Li @blackpiglet Addressed PR feedback and added tests. PTAL, Thanks !
Thank you for contributing to Velero!
Please add a summary of your change
Implementation PR for Extend Volume Policies feature to support more actions
Related design: https://github.com/vmware-tanzu/velero/pull/6956
Does your change fix a particular issue?
Fixes https://github.com/vmware-tanzu/velero/issues/6640
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.