vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes

https://velero.io

Apache License 2.0

8.65k stars 1.39k forks source link

Bump up to go1.22 #7666

Closed reasonerjt closed 5 months ago

reasonerjt commented 5 months ago

Bump up the golang version to v1.22

It also updates controller-gen to v0.14.0 to fix an issue under new version of go. More details see https://github.com/golang/go/issues/65637

It's known that it causes decrease to the coverage on codecov due to the change in go1.22 to calculate coverage

Please indicate you've done the following:

[X] Accepted the DCO. Commits without the DCO will delay acceptance.
[x] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
[ ] Updated the corresponding documentation in site/content/docs/main.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.86%. Comparing base (c888f51) to head (1b3fe95).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #7666 +/- ## ========================================== - Coverage 61.29% 56.86% -4.43% ========================================== Files 276 343 +67 Lines 31490 28391 -3099 ========================================== - Hits 19301 16144 -3157 - Misses 10830 10849 +19 - Partials 1359 1398 +39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

blackpiglet commented 5 months ago

The UT is impacted. Please double-check the change mentioned by @mateusoliveira43.

reasonerjt commented 5 months ago

@blackpiglet

The UT is impacted. Please double-check the change mentioned by @mateusoliveira43.

The coverage may have to be impacted, b/c the go1.22 stopped skipping the packages that do not include _test files, I find it also changed in other details, for example, it stopped taking into some inline comments as covered.