vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes

https://velero.io

Apache License 2.0

8.65k stars 1.39k forks source link

testifylint: enable error-nil rule #7670

Closed mmorel-35 closed 2 months ago

mmorel-35 commented 5 months ago

Please add a summary of your change

testifylint: enable error-nil rule

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

[x] Accepted the DCO. Commits without the DCO will delay acceptance.
[x] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
[ ] Updated the corresponding documentation in site/content/docs/main.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.82%. Comparing base (aa3fde5) to head (4421a9a).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #7670 +/- ## ======================================= Coverage 58.82% 58.82% ======================================= Files 346 346 Lines 28886 28886 ======================================= Hits 16993 16993 Misses 10464 10464 Partials 1429 1429 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mmorel-35 commented 5 months ago

v1.14.0 FC is not far away. Suggest to put on hold of this PR until release-1.14 branch is cut.

Hi @blackpiglet , Any schedule/visibility concerning 1.14.0 FC and the merge of my linting PR ?

blackpiglet commented 5 months ago

@mmorel-35 The branch cut should happen this May.

blackpiglet commented 4 months ago

@mmorel-35 Could you help to resolve the conflict?

mmorel-35 commented 4 months ago

@mmorel-35 Could you help to resolve the conflict?

@blackpiglet, that’s ready 👍!

mmorel-35 commented 2 months ago

Any chance this can be merged ?