vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.45k stars 1.37k forks source link

[bug] CSI plugin Poll timeout error check #7675

Closed anshulahuja98 closed 3 months ago

anshulahuja98 commented 3 months ago

What steps did you take and what happened:

The refactor has introduced a bug where this condition is checking onthe wrong value. https://github.com/vmware-tanzu/velero-plugin-for-csi/blob/2b15f04b970523f410008b00d7687bf1e2ec6ffb/internal/util/util.go#L270C2-L270C87

The check should instead be - wait.Interrupt(err) - based on wait package documentation. What did you expect to happen:

The following information will help us better understand what's going on:

If you are using velero v1.7.0+:
Please use velero debug --backup <backupname> --restore <restorename> to generate the support bundle, and attach to this issue, more options please refer to velero debug --help

If you are using earlier versions:
Please provide the output of the following commands (Pasting long output into a GitHub gist or other pastebin is fine.)

Anything else you would like to add:

Environment:

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

reasonerjt commented 3 months ago

@blackpiglet could you please check?

anshulahuja98 commented 3 months ago

Fixed in https://github.com/vmware-tanzu/velero/pull/7661