vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes

https://velero.io

Apache License 2.0

8.65k stars 1.39k forks source link

Merge makefile for e2e perf test #7701

Closed qiuming-best closed 5 months ago

qiuming-best commented 5 months ago

Thank you for contributing to Velero!

Please add a summary of your change

Merging e2e test makefile and perf test makefile into one makefile. only modifying one makefile when Parameters change for both tests.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

[ ] Accepted the DCO. Commits without the DCO will delay acceptance.
[ ] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
[ ] Updated the corresponding documentation in site/content/docs/main.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.49%. Comparing base (f04fbbc) to head (a0fb739).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #7701 +/- ## ======================================= Coverage 58.49% 58.49% ======================================= Files 343 343 Lines 28486 28486 ======================================= Hits 16664 16664 Misses 10406 10406 Partials 1416 1416 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sseago commented 5 months ago

@qiuming-best @blackpiglet I approved this one, but I noticed that the linter seems to be failing. Looking at the output, I see a bunch of errors that shouldn't be errors -- any idea whether something is off with the configuration? Could the bump up to golang 1.22 have broken something?

qiuming-best commented 5 months ago

@qiuming-best @blackpiglet I approved this one, but I noticed that the linter seems to be failing. Looking at the output, I see a bunch of errors that shouldn't be errors -- any idea whether something is off with the configuration? Could the bump up to golang 1.22 have broken something?

@sseago This is because PR add some strict checks for test directory. And @blackpiglet will help to solve it.

blackpiglet commented 5 months ago

@sseago It should relate to the Golang version bump. This PR #7697 also contains the linter fix code.