vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.42k stars 1.37k forks source link

Need a confirm flag for velero plugin add CLI #7726

Closed danfengliu closed 2 months ago

danfengliu commented 2 months ago

Describe the problem/challenge you have In E2E test, velero plugin add CLI is involved in additional BSL test, so we need a-y/-n flag and -nas the default input for this CLI so that no Human-Computer Interaction is needed for automatic tests.

installPluginCmd cmd =/velero/workspace/velero-e2e-test/e2e/velero/test/e2e/../../_output/bin/linux/amd64/velero --namespace velero plugin add velero/velero-plugin-for-aws:main
velero plugin add may cause the Velero server pod restart, so it is a dangerous operation
once Velero server restarts, all the ongoing jobs will fail.
Are you sure you want to continue (Y/N)? error reading user input: EOF

Describe the solution you'd like

Anything else you would like to add:

Environment:

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

kaovilai commented 2 months ago

Thank you!

kaovilai commented 2 months ago

Related to #7566