vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.42k stars 1.37k forks source link

Context timeout control of test interface(test.go) is not effective in E2E test #7738

Closed danfengliu closed 2 months ago

danfengliu commented 2 months ago

What steps did you take and what happened: Ctx of TestCase is not effective due to missing understanding of Ginkgo test schedule behavior, Ctx should not be set outside of ginkgo keywords like IT or BeforeEach, etc. otherwise, Ctx will be set at the very beginning of test execution instead of beginning of each individual test.

What did you expect to happen:

The following information will help us better understand what's going on:

If you are using velero v1.7.0+:
Please use velero debug --backup <backupname> --restore <restorename> to generate the support bundle, and attach to this issue, more options please refer to velero debug --help

If you are using earlier versions:
Please provide the output of the following commands (Pasting long output into a GitHub gist or other pastebin is fine.)

Anything else you would like to add:

Environment:

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

danfengliu commented 2 months ago

Close as completed in PR #7590.