vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.41k stars 1.37k forks source link

Add existingResourcePolicy restore CR validation to controller. #7757

Closed kaovilai closed 1 month ago

kaovilai commented 2 months ago

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7347

Please indicate you've done the following:

anshulahuja98 commented 2 months ago

@kaovilai CI is failing, can you pl check Verifying goimports - failed! Please run 'make update'.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.66%. Comparing base (8f78aaa) to head (3c937d4). Report is 16 commits behind head on main.

Files Patch % Lines
pkg/cmd/cli/restore/create.go 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7757 +/- ## ========================================== + Coverage 58.64% 58.66% +0.01% ========================================== Files 344 345 +1 Lines 28720 28733 +13 ========================================== + Hits 16843 16856 +13 - Misses 10447 10448 +1 + Partials 1430 1429 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaovilai commented 2 months ago

Fixed make update! Thanks all.

kaovilai commented 1 month ago

labels PR fix https://github.com/vmware-tanzu/velero/pull/7776