vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.63k stars 1.39k forks source link

Use native cache from actions/setup-go #7768

Closed mmorel-35 closed 1 month ago

mmorel-35 commented 5 months ago

Thank you for contributing to Velero!

Please add a summary of your change

Use native cache from actions/setup-go instead of defining actions/cache for ~/go/pkg/mod path

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.80%. Comparing base (64d8014) to head (5129a97). Report is 34 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7768 +/- ## ======================================= Coverage 58.80% 58.80% ======================================= Files 358 358 Lines 30085 30085 ======================================= Hits 17692 17692 Misses 10945 10945 Partials 1448 1448 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mmorel-35 commented 5 months ago

/kind changelog-not-required

mmorel-35 commented 4 months ago

/kind changelog-not-required

reasonerjt commented 4 months ago

Doesn't have to be in v1.14.0? I'd propose we delay it after v1.14.0 RC

mmorel-35 commented 4 months ago

Doesn't have to be in v1.14.0?

I agree, no need

blackpiglet commented 4 months ago

/kind changelog-not-required

blackpiglet commented 4 months ago

/kind changelog-not-required

mmorel-35 commented 3 months ago

@reasonerjt , Anything left to merge this now that 1.14 is out ?

blackpiglet commented 3 months ago

@ywk253100 @reasonerjt Please take a look. Ready for review.

mmorel-35 commented 2 months ago

@ywk253100 @reasonerjt,

Would you like to review this when you can find the time 😊?

mmorel-35 commented 1 month ago

Shall the defer-candidate label be removed ?