vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes

https://velero.io

Apache License 2.0

8.41k stars 1.37k forks source link

fix `/kind changelog-not-required` #7769

Closed mmorel-35 closed 2 months ago

mmorel-35 commented 2 months ago

Thank you for contributing to Velero!

Please add a summary of your change

fix /kind changelog-not-required

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

[x] Accepted the DCO. Commits without the DCO will delay acceptance.
[x] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
[ ] Updated the corresponding documentation in site/content/docs/main.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.66%. Comparing base (4d48273) to head (a90c0a4).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #7769 +/- ## ========================================== + Coverage 58.64% 58.66% +0.02% ========================================== Files 344 344 Lines 28720 28720 ========================================== + Hits 16843 16849 +6 + Misses 10447 10442 -5 + Partials 1430 1429 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mmorel-35 commented 2 months ago

Please ignore whitespace changes during review, it's going to be easier

blackpiglet commented 2 months ago

/kind changelog-not-required

reasonerjt commented 2 months ago

Please squash the commits.

blackpiglet commented 2 months ago

/kind changelog-not-required

mmorel-35 commented 2 months ago

/kind changelog-not-required

I believe that the action is reading from the .github/labels.yaml in the main branch of the vmware-tanzu repo not the one from my fork

blackpiglet commented 2 months ago

Thanks. I also think that may work after the PR is merged.

I found something useful from the PROW action document. https://github.com/jpmcb/prow-github-actions/blob/main/docs/labeling.md The PROW action reads the predefined information from the .github/labels.yaml. @reasonerjt

mmorel-35 commented 2 months ago

I found something useful from the PROW action document. https://github.com/jpmcb/prow-github-actions/blob/main/docs/labeling.md The PROW action reads the predefined information from the .github/labels.yaml.

That’s exactly why I changed from labels.yml to labels.yaml 😉