vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.41k stars 1.37k forks source link

split labels configurations add more prow commands #7776

Closed mmorel-35 closed 1 month ago

mmorel-35 commented 1 month ago

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

mmorel-35 commented 1 month ago

/kind changelog-not-required

mmorel-35 commented 1 month ago

Hi @blackpiglet,

It seems that actions/labeler and jpmcb/prow-github-actions configurations are incompatibles as kind is generating an error on actions/label execution.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.66%. Comparing base (3cbf2eb) to head (3650337). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7776 +/- ## ======================================= Coverage 58.65% 58.66% ======================================= Files 344 344 Lines 28730 28731 +1 ======================================= + Hits 16853 16854 +1 Misses 10448 10448 Partials 1429 1429 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaovilai commented 1 month ago

Hi @blackpiglet,

It seems that actions/labeler and jpmcb/prow-github-actions configurations are incompatibles as kind is generating an error on actions/label execution.

Per their doc, it never meant to be the same file.

blackpiglet commented 1 month ago

I agree with @kaovilai. I also made some changes in PR #7775.

mmorel-35 commented 1 month ago

Hi @blackpiglet ,

I integrated those changes here so it's clearly separate the concern of each PR.

mmorel-35 commented 1 month ago

Anyone can second approve to merge this, so #7784 can then be rebased ?

blackpiglet commented 1 month ago

/cc @qiuming-best @Lyndon-Li