vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.4k stars 1.37k forks source link

Update extension of volume policies design #7803

Closed shubham-pampattiwar closed 1 month ago

shubham-pampattiwar commented 1 month ago

Thank you for contributing to Velero!

Please add a summary of your change

Update extension of volume policies design Remove requirement of snapshotVolumes flag for snapshot action

Please indicate you've done the following:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.67%. Comparing base (a0b7382) to head (2adb0a6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7803 +/- ## ======================================= Coverage 58.67% 58.67% ======================================= Files 345 345 Lines 28739 28739 ======================================= Hits 16862 16862 Misses 10448 10448 Partials 1429 1429 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Lyndon-Li commented 1 month ago

@shubham-pampattiwar @blackpiglet I think we should add more details about how volumePolicy works with --snapshotVolume flag in the design, so as to reflect the changes in PR #7794.

blackpiglet commented 1 month ago

Because #7794 already included the design change of VolumePolicy, we can close this PR.

reasonerjt commented 1 month ago

@shubham-pampattiwar I'm closing this one, please ping me on slack if there's different opinion.