IncludedNamespaces in restore skips restore of cluster scoped resources included by backup IncludedNamespaces

[kaovilai]

And yes ! My issue is resolved. User error.

Because I created the Backup CR using

includedNamespaces:
  - myns

I automatically used that in the Restore CR too.. which caused the clusterscoped resources not to be restored. Removing the 'includedNamespaces' directive from the Restore CR caused everything to restore fine !

Thanks Kaovilai and Blackpiglet for your help !

Originally posted by @PieterVoet in https://github.com/vmware-tanzu/velero/discussions/7797#discussioncomment-9456798

[ywk253100]

@kaovilai Seems the issue has already been resolved?

[kaovilai]

User resolved their immediate issue but @sseago and I think there may be some usability enhancements to make include/exclude behave the same on restore as backup.

[ywk253100]

@kaovilai Could you change the description of this issue to clarify why the include/exclude behaviour is inconsistent for backup and restore and which part needs to improve?

[sseago]

@ywk253100 based on the linked issue above, I think what's going on is this: For namespaced backups, related cluster-scoped resources are pulled in -- in the above case, clusterroles and clusterrolebindings For namespaced restores, though, those related cluster-scoped resources are excluded.

Consider these 2 cases. First case:

• single namespace backup, namespace "foo" -- this pulls in clusterroles and clusterrolebindings for the ns
• to restore "foo", just restore the full backup. Everything works.

Second case:

• two namespace backup, namespaces "foo" and "bar" -- this pulls in clusterroles and clusterrolebindings
• now restore just "foo" -- clusterroles/clusterrolebindings are excluded
• now restore just "bar" -- clusterroles/clusterrolebindings are excluded.

It may be that all we need here is corresponding RIAs that pull in related cluster-scoped resources as we do in BIAs.