vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.4k stars 1.37k forks source link

The status.phase of DeleteBackupRequest should be updated as Processed when got error during the processing #7812

Open ywk253100 opened 1 month ago

ywk253100 commented 1 month ago

The status.phase of DeleteBackupRequest isn't updated when got errors during the processing in some cases, the status.phase is stuck in Processing, and the controller will skip it directly when reconciling it again. For example, when using S3 with incorrect credential as the BSL and the code here will return directly without updating the status and leave the DeleteBackupRequest stuck in Processing status.

This causes issues when downstream projects rely on the status.phase to take different actions.