vmware-tanzu / velero

Backup and migrate Kubernetes applications and their persistent volumes
https://velero.io
Apache License 2.0
8.4k stars 1.37k forks source link

Use PVC to track the CSI snapshot in restore #7852

Closed reasonerjt closed 3 weeks ago

reasonerjt commented 4 weeks ago

This commit fixes #7849. It will use PVC instead of PV to track CSI snapshots to generate restore volume info metadata. So that in the case the PVC is not bound to PV the metadata can be populated correctly.

Thank you for contributing to Velero!

Fixes #7849

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 58.79%. Comparing base (ce16acb) to head (f6367ca).

Files Patch % Lines
internal/volume/volumes_information.go 38.09% 12 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.14 #7852 +/- ## ================================================ - Coverage 58.80% 58.79% -0.01% ================================================ Files 345 345 Lines 28759 28765 +6 ================================================ + Hits 16911 16913 +2 - Misses 10420 10423 +3 - Partials 1428 1429 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

reasonerjt commented 3 weeks ago

For some reason, the DCO check is pending on the status Waiting for status to be reported

I will temporarily remove it from the required checks.